forked from kubeflow/kubeflow
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-15741: Sync v1.9-branch branch with main branch #458
Merged
jiridanek
merged 9 commits into
opendatahub-io:v1.9-branch
from
jiridanek:jd_merge_branch
Nov 15, 2024
Merged
RHOAIENG-15741: Sync v1.9-branch branch with main branch #458
jiridanek
merged 9 commits into
opendatahub-io:v1.9-branch
from
jiridanek:jd_merge_branch
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes inspiration from: * The Notebooks 2.0 Dockerfile, which comes from a default recent Kubebuilder template, at https://github.com/kubeflow/notebooks/blob/notebooks-v2/workspaces/controller/Dockerfile * The Red Hat build Dockerfile (that's the Cachito part) in an internal repository. This change brings multiple improvements: 1. Dockerfiles are brought closer together, especially to the Red Hat build; previously, sourcing things in a stand-alone RUN command had no effect 2. The openssl fips-compatible library is linked into the manager binaries, to proactively address fips concerns
…provements RHOAISTRAT-214: Issue opendatahub-io#362: feat(nbcs): build containers to be fips-ready
Shorter certificates fit better on the screen.
…ests NO-JIRA: tests(odh-nbc): shorten the test certificates
…99976 [GHA] Update odh and notebook-controller with image main-363bcdb
…tahub-io#456) Turns out that this "impacted but not vulnerable" prodsec thing is around to haunt us. This way we'll have full info from govulncheck so that we can better assess various reports.
openshift-merge-robot
added
the
needs-rebase
The PR needs a rebase or there are conflicts
label
Nov 15, 2024
This comment was marked as outdated.
This comment was marked as outdated.
jiridanek
force-pushed
the
jd_merge_branch
branch
from
November 15, 2024 09:57
da3ab1d
to
e720ba0
Compare
jiridanek
added
approved
and removed
needs-rebase
The PR needs a rebase or there are conflicts
labels
Nov 15, 2024
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-15741
v1.9-branch...opendatahub-io:kubeflow:main